fix(streams): prevent earlyZipReadableStreams() from possibly using excessive memory
#5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5082 +/- ##
==========================================
- Coverage 92.51% 92.51% -0.01%
==========================================
Files 481 481
Lines 38722 38719 -3
Branches 5444 5441 -3
==========================================
- Hits 35822 35819 -3
Misses 2845 2845
Partials 55 55 ☔ View full report in Codecov by Sentry. |
iuioiua
suggested changes
Jun 19, 2024
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
iuioiua
changed the title
earlyZipReadableStreamsearlyZipReadableStreams() from possibly using excessive memory
iuioiua
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
I made a final tweak to the cancel reason. Thank you very much, @BlackAsLight. Great work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jumping from: #5078 (comment)
This pull request changes the structure of the readable stream to use a pull method instead of the start method, stopping it from the possibility of using excessive memory, possibly overflowing it if not consumed fast enough, or at all. This alternative also offers a way to cancel the provided reason streams from the returned stream.
Current Version - overloaded the memory
Alterative Version
Benchmark
This refactor did turn out to be slightly slower than the existing one in a benchmark.
